OD2
OD2 copied to clipboard
[MVP QA] Validate edited/changed data
Descriptive summary
This is used by the bulk ingest, single ingest form, and any editing. We need to figure out what validation is actually happening in current OD, and use this as a basis for this implementation.
Expected behavior
Form
- [x] Browse/search for an extant work
- [x] Add a value to a field requiring a URL (see MAP)
- [x] Add a value to a field that requires a date (see MAP)
- [x] Add a value to a field that requires text (see MAP)
- [x] Change or add a file to the work
- [x] Change or add an oEmbed to the work
- [x] Confirm field values have been updated (with correct label on front end and the more info icon links to the external authority for URL-requiring field)
- [x] Confirm field values appear correctly in nts
- [x] Confirm file now appears in fileset with correct data
- [x] Confirm derivatives (thumb, standard size) and full size files are visible and downloadable
- [x] Confirm oEmbed is visible/playable
Bulk
- [ ] Browse/search for an extant work(s), use Exporters to download csv
- [x] Add a value to a field requiring a URL (see MAP)
- [x] Add a value to a field that requires a date (see MAP)
- [x] Add a value to a field that requires text (see MAP)
- [ ] Change or add a file to the work
- [ ] Change or add an oEmbed to the work
- [x] Confirm field values have been updated (with correct label on front end and the more info icon links to the external authority for URL-requiring field)
- [x] Confirm field values appear correctly in nts
- [ ] Confirm file now appears in fileset with correct data
- [ ] Confirm derivatives (thumb, standard size) and full size files are visible and downloadable
- [ ] Confirm oEmbed is visible/playable
Related work
#35, #42, #45
Accessibility Concerns
Some additional QA should include checking validation of fields with data that should not be allowed. This could be different between the Form and Bulk but some ideas are below:
- [x] Attempt to add text to a field that requires a date
- [x] Attempt to add text to a field that requires a URI
- [x] Attempt to add non-URL as an oEmbed
MVP QA #1355 Test Parent work: https://staging.oregondigital.org/concern/images/5t34sj64h?locale=en
As of 2020-12-09:
- Oembed isn't working- will try later
- Not sure how to access .nts in OD2
- Can't QA bulk right now until bulkrax is configured
QA fail: Attempt to add text to a field that requires a date
https://github.com/OregonDigital/OD2/issues/1414
https://github.com/OregonDigital/OD2/issues/360
https://github.com/OregonDigital/OD2/issues/1413
Adding non-URL oEmbed produces an error
Waiting for Bulkrax
Notes:
-The exporter was designed for larger data exports, not single works, so I downloaded the CSV and file directly from the work showpage and then used the importer to do QA steps. -Ticketed up single work selection in the exporter as an enhancement: https://github.com/OregonDigital/OD2/issues/2697 -oEmbed support was not QA'ed because that is also an enhancement and was not part of N8's original work for us. See Ryan's comment here: https://github.com/OregonDigital/OD2/issues/1408
More notes:
-Was able to change/update metadata with bulkrax workaround, but not working as expected. -We cannot QA for file replacing or oEmbed right now due to other errors in code. See: https://github.com/samvera-labs/bulkrax/issues/709 -As mentioned above, the exporter cannot navigate to single items for export.
QA has to be on hold for now until these issues are addressed. @jsimic @shieldsb
Believed to be complete, reworking of verification tasks for newer content is happening in newer tickets such as https://github.com/OregonDigital/OD2/issues/3031