CONQUEST-release icon indicating copy to clipboard operation
CONQUEST-release copied to clipboard

Published 20 hours ago • verified publisher icon OrderN

Reduce code duplication in PAO_grid_transform_module

Open tkoskela opened this issue 1 year ago • 5 comments

The subroutines

https://github.com/OrderN/CONQUEST-release/blob/1378f0359b798362b84177bc4288e97ceff17824/src/PAO_grid_transform_module.f90#L98

and

https://github.com/OrderN/CONQUEST-release/blob/1378f0359b798362b84177bc4288e97ceff17824/src/PAO_grid_transform_module.f90#L270

Duplicate almost all of the code with only minor differences. It would be good for code stability to move the common code into a utility function, or perhaps merge the subroutines into one. Worth keeping in mind if they need refactoring for #198

tkoskela avatar Aug 16 '23 07:08 tkoskela