OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Improvement needed: theme manifest file variable needed

Open JoshTango opened this issue 5 years ago • 2 comments

In the theme manifest file for example using the Agency theme is this line: .SetUrl("~/TheAgencyTheme/vendor/jquery/jquery.min.js", "~/TheAgencyTheme/vendor/jquery/jquery.js")

The string "TheAgencyTheme" gets repeated many times.

Please create a variable for this string and reference the variable in all the lines of code.

JoshTango avatar Dec 09 '19 20:12 JoshTango

Make sense, but while the theme name will not change it's fine

hishamco avatar Dec 09 '19 23:12 hishamco

How would you use this const? The theme name will never change. Or is your issue solely about the dislike of the string literal being repeated?

Piedone avatar Apr 28 '24 21:04 Piedone

It seems that this issue didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please reply.

github-actions[bot] avatar May 26 '24 02:05 github-actions[bot]

Closing this issue because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

github-actions[bot] avatar Jun 03 '24 02:06 github-actions[bot]