OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Add content type filter for ListPart

Open xtomas opened this issue 3 months ago • 4 comments

  • add content type filter for ListPart administration
  • optimize loading contained content types in ListPartDriver

Screenshots of the result:

Content Type filter added to the right of the text search input image

Selecting content types image

Content types filter selected and applied image

Implements #18429

xtomas avatar Oct 03 '25 09:10 xtomas

Thanks for this PR. I would add the filters in the place place as the management screen for consistency and re-usability. Here is where these filter should go. This way, we can "may be in other PR" add sort and other filters if needed.

image

MikeAlhayek avatar Oct 06 '25 20:10 MikeAlhayek

@xtomas have you seen Mike's comment?

Piedone avatar Oct 14 '25 19:10 Piedone

@Piedone yes I have already seen Mike's comment. I actually work on it in my git repository. On a copied Lists code just to be sure it will be available for my project even if my PR will not yet be finished and 3.x version not released. If it will work well, I will update this PR with functional and tested solution.

I also had and idea to enable filtering content picker field in contained types only (for example two content types in a list part and one picking from other, let's say Partner with list of branches and discounts where discount can multiple pick from partner's branches). It was easy to implement but I actually do not need it anymore due to business requirements change. And it is not easy to describe in UI.

xtomas avatar Oct 15 '25 07:10 xtomas

OK, thanks, let us know in a comment here once you've updated the PR.

The contained-type only feature is not something that would be generally too useful, I think, but I'm not sure I fully understand what it's about.

Piedone avatar Oct 15 '25 12:10 Piedone

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Dec 14 '25 12:12 github-actions[bot]