OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Remove SaaS recipe from inner tenants

Open hishamco opened this issue 3 months ago • 7 comments

Addresses https://github.com/OrchardCMS/OrchardCore/discussions/18396

hishamco avatar Sep 22 '25 22:09 hishamco

Tying the Setup and Tenants modules to a recipe in a theme seems like a very hackish dependency. This much rather needs a properly architected general solution. See https://github.com/OrchardCMS/OrchardCore/issues/16229 for ideas. However, I don't think this is too high of a priority now.

Piedone avatar Sep 22 '25 22:09 Piedone

I have a better solution, but I'd like to keep it simple and allow others to implement SaaS in inner tenants if they need

hishamco avatar Sep 22 '25 22:09 hishamco

Then I'd suggest you present that because I don't think this is appropriate to merge.

Piedone avatar Sep 22 '25 22:09 Piedone

BTW there's a flaky tests in Linux I just notice in my last two PRs

hishamco avatar Sep 22 '25 22:09 hishamco

I agree with @Piedone, it seems to be a hack. I think we should leave it as it is for now, or strive for a complete solution. For example, we could have something in the recipes that connects it with the default tenant. Quite similar to the mentioned issue.

gvkries avatar Sep 23 '25 11:09 gvkries

I agree with @Piedone, it seems to be a hack

I agree, and I elaborate why. Let us hear @sebastienros feedback, or someone mention it in the triage

hishamco avatar Sep 23 '25 18:09 hishamco

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Dec 06 '25 04:12 github-actions[bot]