OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Prettify the notifications menu

Open hishamco opened this issue 4 months ago • 10 comments

This PR prittifies the notifications menu as follows:

  • Maximize the notification pop-up width to display the titles properly
  • Fixes the margin, padding, and font sizes
  • Remove unread behavior while the mouse is hovering, coz it isn't very pleasant
  • Use title instead of summary

Before

With notifications

Screenshot 2025-09-13 083720

Without notifications

Screenshot 2025-09-13 083743

After

With notifications

Screenshot 2025-09-13 082208

Without notifications

Screenshot 2025-09-13 082228

hishamco avatar Sep 13 '25 05:09 hishamco

@Piedone, could you please review if you have time?

hishamco avatar Sep 14 '25 19:09 hishamco

@MikeAlhayek is better suited to review this.

Why did you remove initialize from the JS, BTW?

Piedone avatar Sep 14 '25 23:09 Piedone

Why did you remove initialize from the JS, BTW?

Basically, it's used for initializing the item removal from the notifications pop-up, which is annoying, as I mentioned earlier

hishamco avatar Sep 14 '25 23:09 hishamco

How does it look on mobile and how does it look when you have many notifications?

MikeAlhayek avatar Sep 15 '25 00:09 MikeAlhayek

How does it look on mobile and how does it look when you have many notifications?

I didn't change how it looks on mobile, but I will take a screenshot for both cases

hishamco avatar Sep 15 '25 05:09 hishamco

This is how it originally looks when a summary is not supplied

Screenshot 2025-09-17 005726

This is how it originally looks when an HTML summary is used accidentally

Screenshot 2025-09-17 005952

That's why I suggest showing the subject instead

hishamco avatar Sep 16 '25 22:09 hishamco

@hishamco what if you make Summary required then? Or, on the render logic if Sunnary does not have a value, fallback to the Summary. But this may make the admin center look funky.

MikeAlhayek avatar Sep 17 '25 03:09 MikeAlhayek

That's why I'm suggesting using the subject instead, like other apps, I could leave this to a triage meeting

hishamco avatar Sep 17 '25 06:09 hishamco

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Nov 16 '25 16:11 github-actions[bot]

@sebastienros, any chance to revisit this in the upcoming triag meeting

hishamco avatar Nov 25 '25 16:11 hishamco

Can you share a video showing how the change mike mentioned is affected?

sebastienros avatar Dec 11 '25 19:12 sebastienros

Which is one @sebastienros?

hishamco avatar Dec 11 '25 21:12 hishamco