Upgrade bootstrap and fix scrollspy (Lombiq Technologies: NEST-594)
Fixes #18018
Updated to the newest files of the template itself. Then ran yarn build -gr for the wwwroot files.
Not sure what to do with the Validating the Building of Public Assets workflow, tried to add the popperjs in the dependant version, but that did not work.
Is there documentation to troubleshoot this?
Start from here: https://docs.orchardcore.net/en/latest/guides/assets-manager/#prerequisites And run the command not in the wwwroot folder but in the repo root.
Start from here: https://docs.orchardcore.net/en/latest/guides/assets-manager/#prerequisites And run the command not in the wwwroot folder but in the repo root.
Yeah, I did exactly that.
I get the same "error" as the GitHub workflow:
After these, running yarn build -gr succeeds, but then running the same yarn --no-check-resolutions command as the GitHub workflow runs gives back the same issue:
I committed the changed yarn.lock, not sure if that's needed, it's not documented. Now it fails at the "Check if git has changes" step.
I can only recommend you to look into the error message. That, and what comes from CI, suggests an improper NPM installation, what might be possible to solve simply with an npm install.
I can only recommend you to look into the error message. That, and what comes from CI, suggests an improper NPM installation, what might be possible to solve simply with an
npm install.
The error message was not helpful at all. 🥲 It had nothing to do with why the GitHub workflow failed.
My solution: I had to commit the root yarn.lock file after running the yarn commands. Then the "Check if git has changes" step failed in the GitHub workflow, because the yarn commands generated some changes in the Agency project again that I had to commit.
This pull request has merge conflicts. Please resolve those before requesting a review.
@wAsnk feel free to merge when you think it's ready
@wAsnk could you please fix the asset build? I wanted to merge this, seeing it was approved, and tried to fix the merge conflict, but I'm now out of ideas.
This pull request has merge conflicts. Please resolve those before requesting a review.
@wAsnk?
I'll check it now. Sorry about the delayed response.
Thanks!
@Piedone I think this is ready to be merged.
Thank you!