OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Upgrade bootstrap and fix scrollspy (Lombiq Technologies: NEST-594)

Open wAsnk opened this issue 7 months ago • 6 comments

Fixes #18018

wAsnk avatar Jun 12 '25 10:06 wAsnk

Updated to the newest files of the template itself. Then ran yarn build -gr for the wwwroot files.

Not sure what to do with the Validating the Building of Public Assets workflow, tried to add the popperjs in the dependant version, but that did not work.

Is there documentation to troubleshoot this?

wAsnk avatar Jun 13 '25 11:06 wAsnk

Start from here: https://docs.orchardcore.net/en/latest/guides/assets-manager/#prerequisites And run the command not in the wwwroot folder but in the repo root.

Piedone avatar Jun 13 '25 13:06 Piedone

Start from here: https://docs.orchardcore.net/en/latest/guides/assets-manager/#prerequisites And run the command not in the wwwroot folder but in the repo root.

Yeah, I did exactly that.

I get the same "error" as the GitHub workflow: image

After these, running yarn build -gr succeeds, but then running the same yarn --no-check-resolutions command as the GitHub workflow runs gives back the same issue: image

wAsnk avatar Jun 13 '25 14:06 wAsnk

I committed the changed yarn.lock, not sure if that's needed, it's not documented. Now it fails at the "Check if git has changes" step.

wAsnk avatar Jun 13 '25 14:06 wAsnk

I can only recommend you to look into the error message. That, and what comes from CI, suggests an improper NPM installation, what might be possible to solve simply with an npm install.

Piedone avatar Jun 13 '25 14:06 Piedone

I can only recommend you to look into the error message. That, and what comes from CI, suggests an improper NPM installation, what might be possible to solve simply with an npm install.

The error message was not helpful at all. 🥲 It had nothing to do with why the GitHub workflow failed.

My solution: I had to commit the root yarn.lock file after running the yarn commands. Then the "Check if git has changes" step failed in the GitHub workflow, because the yarn commands generated some changes in the Agency project again that I had to commit.

wAsnk avatar Jun 13 '25 14:06 wAsnk

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Jun 24 '25 19:06 github-actions[bot]

@wAsnk feel free to merge when you think it's ready

sebastienros avatar Jun 26 '25 17:06 sebastienros

@wAsnk could you please fix the asset build? I wanted to merge this, seeing it was approved, and tried to fix the merge conflict, but I'm now out of ideas.

Piedone avatar Aug 18 '25 20:08 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Sep 15 '25 21:09 github-actions[bot]

@wAsnk?

Piedone avatar Sep 15 '25 21:09 Piedone

I'll check it now. Sorry about the delayed response.

wAsnk avatar Sep 16 '25 14:09 wAsnk

Thanks!

Piedone avatar Sep 16 '25 14:09 Piedone

@Piedone I think this is ready to be merged.

wAsnk avatar Sep 16 '25 14:09 wAsnk

Thank you!

Piedone avatar Sep 16 '25 15:09 Piedone