OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Add missing docs for OC.Setup

Open hishamco opened this issue 9 months ago • 1 comments

hishamco avatar Apr 15 '25 07:04 hishamco

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Apr 20 '25 00:04 github-actions[bot]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Aug 09 '25 20:08 github-actions[bot]

@Piedone can we merge this?

hishamco avatar Aug 09 '25 21:08 hishamco

Did you address my most recent comment?

Piedone avatar Aug 10 '25 13:08 Piedone

AFAIK yes, that's why you will find two commits after your latest comment

hishamco avatar Aug 10 '25 16:08 hishamco

I checked the code, and it doesn't seem so. Sorry, but I can't allocate any more time to argue for avoiding comments that just state the obvious, so I won't be able to review this PR any further. In its current state I don't approve of it.

Piedone avatar Aug 10 '25 19:08 Piedone

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Oct 09 '25 20:10 github-actions[bot]

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

github-actions[bot] avatar Oct 24 '25 20:10 github-actions[bot]