Upgrade GraphQL to 8.0.2
Fixes #16826.
@hyzx86 you upgraded GraphQL package last time. You may be more familiar with this. Can you please check this out?
IMHO we need to stop bumping the packages ourselves like you said before until the Dependabot is fixed
IMHO we need to stop bumping the packages ourselves like you said before until the Dependabot is fixed
The Dependabot is fixed. But it can't do breaking changes like this one. These will need to always be done manually.
I thought it was straightforward
Anyhow, to try to fix the broken unit tests. @hyzx86 your help appreciated
This problem seems to be related to dynamically generated filtering conditions.
Sorry, I'm busy with other projects recently. It's at a critical stage, and I may not have time to deal with this problem for some time.
Thanks @hyzx86
@MikeAlhayek can you handle this? Or we might need help from @carlwoodhouse or @mdameer who worked recently on some GraphQL PRs
This is going to be a breaking change and should not be part of 2.x. We should wait until 3 before doing this as we have to set ResolvedType instead of Type on all fields (including custom fields in external projects).
So, let us defer this PR then
This pull request has merge conflicts. Please resolve those before requesting a review.
This pull request has merge conflicts. Please resolve those before requesting a review.
Let us defer this for now
Please ignore and keep this PR open until we are ready to tackle it for 3.0
Created https://github.com/OrchardCMS/OrchardCore/issues/16826 to track this.
This pull request has merge conflicts. Please resolve those before requesting a review.
FYI I'm working locally on upgrading GraphQL, If you still want to continue on this let me know to save my time, otherwise I will contribute on the work that I did
FYI I'm working locally on upgrading GraphQL, If you still want to continue on this let me know to save my time, otherwise I will contribute on the work that I did
I am going spend some time on this tomorrow to see if I can identify some of the issues.
Ok, I will hold my work on this, unless you inform me to continue, just to save our time
@sebastienros this is ready
The build is still fail
This pull request has merge conflicts. Please resolve those before requesting a review.
This pull request has merge conflicts. Please resolve those before requesting a review.
This pull request has merge conflicts. Please resolve those before requesting a review.