OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Upgrade GraphQL to 8.0.2

Open MikeAlhayek opened this issue 1 year ago • 14 comments

Fixes #16826.

MikeAlhayek avatar Sep 16 '24 23:09 MikeAlhayek

@hyzx86 you upgraded GraphQL package last time. You may be more familiar with this. Can you please check this out?

MikeAlhayek avatar Sep 16 '24 23:09 MikeAlhayek

IMHO we need to stop bumping the packages ourselves like you said before until the Dependabot is fixed

hishamco avatar Sep 18 '24 15:09 hishamco

IMHO we need to stop bumping the packages ourselves like you said before until the Dependabot is fixed

The Dependabot is fixed. But it can't do breaking changes like this one. These will need to always be done manually.

MikeAlhayek avatar Sep 18 '24 15:09 MikeAlhayek

I thought it was straightforward

Anyhow, to try to fix the broken unit tests. @hyzx86 your help appreciated

hishamco avatar Sep 18 '24 15:09 hishamco

This problem seems to be related to dynamically generated filtering conditions.

Sorry, I'm busy with other projects recently. It's at a critical stage, and I may not have time to deal with this problem for some time.

hyzx86 avatar Sep 18 '24 15:09 hyzx86

Thanks @hyzx86

@MikeAlhayek can you handle this? Or we might need help from @carlwoodhouse or @mdameer who worked recently on some GraphQL PRs

hishamco avatar Sep 18 '24 19:09 hishamco

This is going to be a breaking change and should not be part of 2.x. We should wait until 3 before doing this as we have to set ResolvedType instead of Type on all fields (including custom fields in external projects).

MikeAlhayek avatar Sep 19 '24 16:09 MikeAlhayek

So, let us defer this PR then

hishamco avatar Sep 20 '24 12:09 hishamco

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Sep 23 '24 16:09 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Sep 30 '24 19:09 github-actions[bot]

Let us defer this for now

hishamco avatar Oct 01 '24 16:10 hishamco

Please ignore and keep this PR open until we are ready to tackle it for 3.0

MikeAlhayek avatar Oct 01 '24 17:10 MikeAlhayek

Created https://github.com/OrchardCMS/OrchardCore/issues/16826 to track this.

Piedone avatar Oct 03 '24 23:10 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Oct 04 '24 10:10 github-actions[bot]

FYI I'm working locally on upgrading GraphQL, If you still want to continue on this let me know to save my time, otherwise I will contribute on the work that I did

hishamco avatar Nov 19 '24 21:11 hishamco

FYI I'm working locally on upgrading GraphQL, If you still want to continue on this let me know to save my time, otherwise I will contribute on the work that I did

I am going spend some time on this tomorrow to see if I can identify some of the issues.

MikeAlhayek avatar Nov 20 '24 04:11 MikeAlhayek

Ok, I will hold my work on this, unless you inform me to continue, just to save our time

hishamco avatar Nov 20 '24 10:11 hishamco

@sebastienros this is ready

MikeAlhayek avatar Nov 21 '24 17:11 MikeAlhayek

The build is still fail

hishamco avatar Nov 21 '24 18:11 hishamco

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Nov 21 '24 19:11 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Nov 21 '24 19:11 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Nov 21 '24 20:11 github-actions[bot]