OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

fix validation error rendering on radio/checkbox

Open ns8482e opened this issue 1 year ago • 3 comments

fix validation error rendering on radio/checkbox Before image

After

image

ns8482e avatar Aug 28 '24 21:08 ns8482e

Oops, there's an error in testing assets

hishamco avatar Aug 28 '24 21:08 hishamco

Oops, there's an error in testing assets

updated assets

ns8482e avatar Aug 28 '24 22:08 ns8482e

@ns8482e you'll need to run gulp rebuild-assets on your machine and commit the generated files.

You can also try running npm run cleanup all && npm install && gulp rebuild and commit the files

MikeAlhayek avatar Aug 28 '24 22:08 MikeAlhayek

See https://docs.orchardcore.net/en/latest/guides/gulp-pipeline/#using-the-command-line and be sure to use Node.js 18. Before requesting review again, make sure to revert all the unnecessary file changes so only the SCSS one remains.

Piedone avatar Aug 29 '24 01:08 Piedone

Yes! something is not right, I am using windows 😂

I build all this in fresh brach from main all cleaned and rebuild as @MikeAlhayek suggested

I'll try with fresh clone too

ns8482e avatar Aug 29 '24 10:08 ns8482e

I spent some time on this. no luck. I don't have more time to keep trying. sorry

MikeAlhayek avatar Aug 29 '24 16:08 MikeAlhayek