OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Auto-merge PRs after approve at the end of Functional Tests

Open Piedone opened this issue 1 month ago • 10 comments

Is your feature request related to a problem? Please describe.

Functional Tests run after PR feedback submissions. In case you as a reviewer approve a PR, and you don't need a second opinion, you need to wait around for the tests to finish before merging the PR.

Describe the solution you'd like

Change the functional_all_db workflow to merge the PR if all of the following are true:

  • The trigger was pull_request_review.
  • All reviewers approved (i.e. there are no reviews with "changed requested" open).
  • There's no "don't merge" label on the PR.
  • The PR is not a draft one.

Describe alternatives you've considered

GitHub's auto-merge can do this, but for that, Functional Tests would need to be required checks, i.e. mandatorily run for every PR (they currently don't run for some paths).

Piedone avatar May 16 '24 20:05 Piedone