OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

It is confusing to branch source code from a specific release.

Open MichaelPetrinolis opened this issue 2 years ago • 4 comments

Previously, each version had a release/* branch. From 1.7 and upwards, no release branch is created (or made public), and it is confusing where to get the source code for a release.

For example, regarding the v1.8 release, there are 1.8.0, 1.8.1, 1.8.2 tags in source, but the commit related to v1.8.2 is not in the main branch. "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository."

So, when you sync your fork, you do not have the release code to branch and make a fix.

MichaelPetrinolis avatar Feb 20 '24 12:02 MichaelPetrinolis

@MikeAlhayek did you delete the release branches? In my local clone, I have a release/1.8 branch. Also, the 1.8.2 tag is indeed strange and should rather be on a commit in this repo.

Barring the 1.8.2 tag issue, not having a branch shouldn't be a problem. You should always rather work with tags.

Piedone avatar Feb 21 '24 01:02 Piedone

It looks like it was auto deleted

https://github.com/OrchardCMS/OrchardCore/pull/15117

I think we can create a branch using that hash id

MikeAlhayek avatar Feb 21 '24 01:02 MikeAlhayek

Yes branch are never really deleted you can restore them back.

In "Fork client" you need to use (View --> Show Lost Commits (Reflog))

Skrypt avatar Feb 21 '24 13:02 Skrypt

release/1.8 is there now

MikeAlhayek avatar Feb 21 '24 21:02 MikeAlhayek