OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Media Gallery Vue 3

Open Skrypt opened this issue 2 years ago • 27 comments

Work in progress.

The goal here is first to migrate all the components and SFC to Vue 3. We cannot use new Vue with Vue 3 so some components will need to be refactored.

Also, the components dynamic loading methods need to be removed in favor of using a wrapping component with props simply. Favor usage of Vite with Vue 3 apps/components.

Tasks

  • [ ] Migrate Media Library to Vue 3
  • [ ] Migrate MediaField Media Picker to Vue 3
  • [ ] Make Media Library (standalone) by using a different modal than the Bootstrap one. https://vue-final-modal.org/
  • [ ] Make Media Library (standalone) by using display Flex and Grid simply instead of using Bootstrap classes for styling.
  • [ ] Check if it #15569 is fixed by this; if yes, close it.
  • [ ] Check for other Media issues that might be fixed by this.
  • [ ] Make thumbnail view optional
  • [ ] Add a Swagger/OpenApi module for Media Gallery ApiController
  • [ ] Normalize API requests responses. Make use of ProducesResponseType in Api controller.
  • [ ] Add SignalR notifier. Which means we need to have a SignalR client implementation.
  • [ ] Upgrade Azure Blob storage to latest

Fixes https://github.com/OrchardCMS/OrchardCore/issues/7110.

Optional

Consider refactoring upload bits by using Uppy instead of JQuery FileUpload as it is now archived and old.

See:

https://uppy.io/ https://tus.io/ https://github.com/tusdotnet/tusdotnet https://www.ietf.org/archive/id/draft-tus-httpbis-resumable-uploads-protocol-00.html

Skrypt avatar Sep 01 '23 15:09 Skrypt

@piedone This one will be my only concern in the short term.

Skrypt avatar Jan 11 '24 16:01 Skrypt

Gotcha!

Piedone avatar Jan 11 '24 16:01 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 02 '24 21:02 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 09 '24 04:02 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 12 '24 15:02 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 16 '24 17:02 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 21 '24 23:02 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 27 '24 19:02 github-actions[bot]

Working in OC.

image

Working as standalone (using a baseHost)

image

Works fine here @hyzx86

        <media-app
          site-id="xtwa3swgv9favzbynjd81d8e5v"
          base-host="https://localhost:5001"
          base-path=""
          upload-files-url="/api/media/upload"
          :max-upload-chunk-size="0"
        ></media-app>

Skrypt avatar Mar 23 '24 16:03 Skrypt

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Apr 08 '24 22:04 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Apr 09 '24 16:04 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Apr 18 '24 17:04 github-actions[bot]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Jun 18 '24 02:06 github-actions[bot]

Of course bot I will pick it up at some time in the future 😄

Skrypt avatar Jun 18 '24 02:06 Skrypt

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Jun 21 '24 17:06 github-actions[bot]

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

MikeAlhayek avatar Aug 15 '24 17:08 MikeAlhayek