OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Published 20 hours ago • verified publisher icon OrchardCMS

[Prototype] Update the OpenID module to use the OpenIddict client

Open kevinchalet opened this issue 1 year ago • 4 comments

This is a very crude PR that replaces the MSFT OIDC handler in OrchardCore.OpenId by the OpenIddict client. I deliberately didn't touch the OpenID client recipe to avoid a source/binary breaking change and used multiple mappings to avoid behavior changes.

Open questions:

  • Do we want to support configuring multiple client registrations (to connect with multiple OpenID Connect servers)? It's not something currently supported by the OpenID client feature and would likely require changes to the UI/recipes.
  • Do we want to use OpenIddict's web providers? If so, how do we architecture things? Do we want to merge the Facebook/Google/GitHub/Entra ID/Twitter modules into OrchardCore.OpenId?

Related discussion: https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/issues/90.

/cc @hishamco @MichaelPetrinolis

kevinchalet avatar Jul 21 '23 13:07 kevinchalet

So this depends on https://github.com/OrchardCMS/OrchardCore/pull/7891, right?

Piedone avatar Jan 18 '24 21:01 Piedone

So this depends on https://github.com/OrchardCMS/OrchardCore/pull/7891, right?

Technically, we could use the same X.509 certificates generation logic as the server feature but since it's something we want to get rid of once the secrets module is ready, it's likely better to just wait so yeah 😃

kevinchalet avatar Jan 18 '24 22:01 kevinchalet

OK then, thank you. I think it's better as a draft, then, for now.

Piedone avatar Jan 18 '24 23:01 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Feb 08 '24 22:02 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar May 24 '24 16:05 github-actions[bot]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Jul 23 '24 16:07 github-actions[bot]

Rebased on top of main.

kevinchalet avatar Jul 23 '24 17:07 kevinchalet

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Aug 14 '24 13:08 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Aug 16 '24 20:08 github-actions[bot]