Implement configuration provider-based settings for the ReCaptcha module
Is your feature request related to a problem? Please describe.
You currently need to configure ReCaptcha settings from settings. This is a good and necessary way to do it, but for environment-based settings (like different for staging and prod) it'd be better to have them configurable via configuration providers too. ReCaptchaSettings is almost ready for this.
Describe the solution you'd like
Similar to what we have in a lot of other modules:
- Provide an extension method to do environment configuration, similar to
ConfigureAzureADSettings(). - Check that everywhere where
ReCaptchaSettingsis used, it's used as anIOptions<ReCaptchaSettings>and not directly as site settings (except when the site settings are edited). E.g.ReCaptchaLoginFilterdirectly goes to site settings instead of going the options way. - Add corresponding docs.
This looks like a good first issue, since you just have to follow the pattern of existing implementations.
Describe alternatives you've considered
None.
FYI @hishamco if you're interested and no one else takes on it.
I saw it yesterday, but I was busy at that time .. hope to reply soon
is this issue resolved?
I don't think so
Hi @Piedone, Can I take up this issue ?
Sure, that would be great! Let me know when you're done and I can review.
Thank you! I hope I can use this thread to ask questions if I face any blockers.
@Harrish-Selvarajah I assigned this to you
Will you work on this any time soon, @Harrish-Selvarajah?
Hey @Piedone , Work has been a bit hectic the past weeks. I'm planning to put some time this weekend.
OK, thanks!
Hi @Piedone, I'm following up on the reported issue. Could you please confirm if this enhancement is done, or if there have been any updates or resolutions since your last report?
There hasn't been any work done on this to my knowledge.
Appologies, I couldn't find the time to work on this problem. If anyone is willing to contribute their time, please do!
I'll take the ticket and raise a pr soon. Thank you.
Hello. Is anyone working with this issue?
@Harrish-Selvarajah was planning to take it, but not
@meijiro-yumeru feel free to take it
I’ll see what I can do, I’m just asking just in case if I could give it a try.
The implementation would involve using Envrionment variable via a web service(i.e. using Amazon Aws, Google Cloud Provider, etc)?
While the configs might ultimately come from an env var, you mustn't read those directly. This issue is about reading values from IShellConfiguration and use the ASP.NET Core configuration provider concept. See https://docs.orchardcore.net/en/latest/reference/modules/Configuration/.