OrchardCore GetCurrentThemeNameAsync() -> GetSiteThemeNameAsync()

This change made to make ISiteThemeService similar to IAdminThemeService in terms of APIs

Jul 23 '22 13:07 hishamco

The difference here is that SiteTheme is a tenant-scoped service. Maybe it would be better that the name reflects it. Just an idea. Or add a comment somewhere about it.

Jul 26 '22 18:07 Skrypt

The difference here is that SiteTheme is a tenant-scoped service.

Also the AdminTheme is tenant-scoped, while we can set admin theme per tenant, Am I right?

The context here is to make both classes has similar APIs while the difference is one sets the site theme and the other sets the admin theme

Jul 27 '22 03:07 hishamco

You are right, my brain collapsed. 😄

Jul 27 '22 06:07 Skrypt

No problem it happen ;)

Jul 27 '22 06:07 hishamco

I approve once we agree on the new name.

Sep 07 '22 00:09 Skrypt

@sebastienros are you agree with the name? We should be consistent in terms of naming APIs

Sep 07 '22 07:09 hishamco

Finally merged :)

Aug 03 '23 19:08 hishamco

you're welcome lol. It pays to join the meeting

Aug 03 '23 19:08 MikeAlhayek

Hope to join you in the upcoming meetings.

Aug 04 '23 09:08 hishamco