OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Bootstrap 5.2

Open agriffard opened this issue 3 years ago • 2 comments

https://www.npmjs.com/package/bootstrap/v/5.2.1 https://github.com/twbs/bootstrap/releases/tag/v5.2.1

https://getbootstrap.com/docs/5.2/migration/

  • [ ] Replace div with class dropdown-menu by ul li everywhere needed
  • [ ] Check package.json dependencies in OrchardCore.Workflows

agriffard avatar Jul 20 '22 10:07 agriffard

5.2.0 will allow some modifications on the dark mode and how we implemented it too. Well, I need to try it at least.

https://getbootstrap.com/docs/5.2/migration/#more-css-variables

Skrypt avatar Jul 20 '22 13:07 Skrypt

Updating the Workflow module Bootstrap components will break the popovers and modals. The module probably needs a refresh because these javascript components have been changed in BS 5.

Skrypt avatar Sep 08 '22 23:09 Skrypt

The searchable dropdown lists used int the filters of the content items admin page should also be adapted to the 5.2 changes.

They rely on bootstrap-select and I'm afraid we will have to wait a long time before this BS version is supported.

agriffard avatar Oct 05 '22 19:10 agriffard

@agriffard @Skrypt

Just a thought on this upgrade. I think we can take advantage of the new text-bg-dark and text-bg-dark to make it easy to change between dark and light theme. Currently we use bg-primary class for card to change the background. I think we should text-bg-light and text-bg-dark instead.

MikeAlhayek avatar Oct 31 '22 16:10 MikeAlhayek

@Skrypt will this PR fix #11703 ?

MikeAlhayek avatar Dec 11 '22 19:12 MikeAlhayek