OrchardCore
OrchardCore copied to clipboard
#10849 Liquid syntax support for CorrelateTask
fixes #10849
this is how it works:
https://user-images.githubusercontent.com/6403130/179355188-7f62d94a-532b-4e02-b18d-9a1e45772c2e.mp4
/cc @Skrypt
Seems there's a breaking changes
Seems there's a breaking changes
@hishamco no, there is not
here you have recipe from OC before that PR, and you can test it with this PR, and see that, this feature has backward compatibility
This pull request has merge conflicts. Please resolve those before requesting a review.
@piedone maybe we should take a look more often to PR marked with "need triage" on thursday meetings. I've been trying to make @sebastienros to take a look at those by marking these with that tag. I think I had no comment to add on the PR and it just needed triage.
Sure, please bring them up. I think we only need to triage PRs on the meeting when there's something to discuss with the wider audience (this PR is like that, then?), i.e. you as a reviewer aren't sure.
Please keep to these @lampersky:
- Apply code suggestions directly so the reviewer doesn't have to eyeball the changes. These resolve themselves after applying them, that's fine.
- Don't resolve other conversations so it's easier to track for the reviewer. Then, the reviewer will resolve them.
- Feel free to mark conversations that you addressed to keep track of them with an emoji or otherwise, just don't resolve them.
- Please keep conversations happening in line comment in those convos, otherwise communication will be a mess. If you have trouble finding them, see this video.
- Please click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done.
When you're done addressing all feedback of a review, click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done.