Fixing accessibility problems and HTML validation errors in built-in themes (Lombiq Technologies: OCORE-83)

[DemeSzabolcs]

Fixes #11242 This PR doesn't include fixes for: 25:55 error The autoplay attribute is not allowed on <video> no-autoplay HTML validation error in The Coming Soon Theme, because I think the auto-playing video is a crucial part of that theme. Also, there are overlays on the video, and it's in the background, so it's not that disturbing.

[dnfadmin]

All CLA requirements met.

[Skrypt]

Please open a PR on the appropriate repository else we will restart fixing those when we will update these themes later on.

[hishamco]

I don't think this PR should go in OC

[Piedone]

Following up from the issue, I think:

• The Liquid code is derivative work, part of Orchard, we own and need to fix those. Same with the recipe.
• The HTML files are coming directly from the themes. We need to fix these there with a PR under https://github.com/StartBootstrap/startbootstrap-agency and https://github.com/StartBootstrap/startbootstrap-coming-soon. Then once merged, we need to update them here.

In any case, all of these issues need to be fixed one way or another.

[DemeSzabolcs]

I created PRs on the appropriate repositories: The Coming Soon theme: https://github.com/StartBootstrap/startbootstrap-coming-soon/pull/62 The Agency theme: https://github.com/StartBootstrap/startbootstrap-agency/pull/323 The Agency theme insufficient color contrast issue: https://github.com/StartBootstrap/startbootstrap-agency/issues/322 The Default theme insufficient color contrast issue: https://github.com/StartBootstrap/startbootstrap-bare/issues/58

[Piedone]

I don't think there's any point in waiting more for those theme projects that didn't react to your issues. Please wrap this up with everything that's readily usable, including updating Agency, since that was fixed (https://github.com/StartBootstrap/startbootstrap-agency/pull/323).

[DemeSzabolcs]

including updating Agency

I just checked, I already updated it here in the way that the PR was accepted in its own repository.

[DemeSzabolcs]

@Piedone

This does not fix #11241, right?

No because of these: https://github.com/StartBootstrap/startbootstrap-coming-soon/pull/62 https://github.com/StartBootstrap/startbootstrap-agency/issues/322 https://github.com/StartBootstrap/startbootstrap-bare/issues/58

Since due to the autoplay video remaining this does not fully fix #11242 please factor that problem out to its own issue.

We talked about this internally way back. The video is in the background, so there is no way to start it manually. And the conclusion was that it could remain.

[Piedone]

OK!