OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Add graphql types to the Seo module

Open dannyd89 opened this issue 3 years ago • 10 comments

This PR fixes #11199

Added ObjectGraphTypes for SeoMetaPart and needed to add one for MetaEntry, too. I'm not sure if OrchardCore.Seo is the right place for the ObjectGraphType for MetaEntry though, so I would like some feedback on that.

Rest is working fine: image

dannyd89 avatar Feb 18 '22 14:02 dannyd89

CLA assistant check
All CLA requirements met.

dnfadmin avatar Feb 18 '22 14:02 dnfadmin

@sebastienros Dont who to ping to look at this but I think it's somewhat in a reviewable state now

dannyd89 avatar Mar 02 '22 11:03 dannyd89

@dannyd89 is your PR ready or still WIP?

hishamco avatar Mar 02 '22 15:03 hishamco

@hishamco I removed the WIP label, this is ready for PR

dannyd89 avatar Mar 02 '22 15:03 dannyd89

Also I'm not sure how to make the SeoMetaPart fields queriable since I'm getting an exception in GraphiQL currently. Do I need to add an IndexAliasProvider in the same fashion as for example AutoroutePart has one?

I'm not sure about that one, need to ask @carlwoodhouse but that would definitely make sense.

Skrypt avatar Mar 02 '22 16:03 Skrypt

Also I'm not sure how to make the SeoMetaPart fields queriable since I'm getting an exception in GraphiQL currently. Do I need to add an IndexAliasProvider in the same fashion as for example AutoroutePart has one?

I'm not sure about that one, need to ask @carlwoodhouse but that would definitely make sense.

This one is already fixed with the current commit, I'll work on your feedback as soon as I have some time on my hand, thanks

dannyd89 avatar Mar 02 '22 16:03 dannyd89

@sebastienros I addressed your feedback and removed all the indexing etc

dannyd89 avatar Apr 04 '22 09:04 dannyd89

I recreated the internal SEO module with my code as an own module and we are currently using it successfully. Is there still something I can do to close this? Else we will stick with our own module.

dannyd89 avatar May 31 '22 16:05 dannyd89

Waiting on release 1.4 before anything.

Skrypt avatar May 31 '22 16:05 Skrypt

Waiting on release 1.4 before anything.

Thanks for the reply, I'll wait and continue to use my module then for the time being

dannyd89 avatar May 31 '22 16:05 dannyd89

Hi is there any progress on this issue? I would be very nice to have these fields in graphql? Maybe I can help to resolve the merge conflicts if you like to.

ThiemeNL avatar Jan 28 '23 20:01 ThiemeNL

I was still waiting on approvement for this, I would be happy if this PR could resolved/merged at some point

dannyd89 avatar Feb 14 '23 14:02 dannyd89

I was still waiting on approvement for this, I would be happy if this PR could resolved/merged at some point

Done!!

hishamco avatar Feb 15 '23 21:02 hishamco

GeoPointField also have same problems

nerd3717 avatar Aug 10 '23 10:08 nerd3717

Please resolve the conflict

hishamco avatar Aug 10 '23 11:08 hishamco

Closed?!!

hishamco avatar Aug 10 '23 12:08 hishamco

Sorry for the confusion, should be good now

dannyd89 avatar Aug 10 '23 13:08 dannyd89