OrchardCore.Commerce icon indicating copy to clipboard operation
OrchardCore.Commerce copied to clipboard

.NET 6.0 application bootstrapping (OCC-71)

Open Skrypt opened this issue 4 years ago • 5 comments

As suggested by @jhgbrt

It would be a good thing to use the new way of bootstrapping the application in .NET 6.0 Maybe there is a way to use it even if we are multi-targeting frameworks on the CI.

Jira issue

Skrypt avatar Dec 03 '21 23:12 Skrypt

@DAud-IcI please confirm that this is addressed by https://github.com/OrchardCMS/OrchardCore.Commerce/pull/119

barthamark avatar May 02 '22 10:05 barthamark

Nope, SampleWebApp still uses the generic host builder style. #119 didn't do functional changes unless it seemed necessary.

Maybe there is a way to use it even if we are multi-targeting frameworks on the CI.

What other frameworks do you have in mind, @Skrypt ? I think we only need to target .Net 6, becuase that's what OC 1.3 requires.

sarahelsaig avatar May 02 '22 22:05 sarahelsaig

Even though we currently only target net6.0; when net7.0 will be eventually out, we will surely multi-target to keep an LTS version in the build pipeline. So, you need to keep in mind that we are going to eventually multi-target.

Skrypt avatar May 02 '22 22:05 Skrypt

Yes, that makes sense. I just got confused, becuase the new style application boostrapping should be forward-compatible so .Net 7 wouldn't have any effect on the issue topic.

We could take a look at multi-targeting with the 7.0.0-preview.3 SDK (in a container, becuase installing preview SDKs on bare metal is never a good time). But that should be a separate issue, I think.

sarahelsaig avatar May 02 '22 23:05 sarahelsaig

I believe this is why we dropped net3.1 and net5.0.

Skrypt avatar May 03 '22 01:05 Skrypt

Looks like this was done during https://github.com/OrchardCMS/OrchardCore.Commerce/issues/212#issuecomment-1285748447 (see the diff here)

sarahelsaig avatar Nov 09 '23 12:11 sarahelsaig