OrchardCore.Commerce icon indicating copy to clipboard operation
OrchardCore.Commerce copied to clipboard
verified publisher icon OrchardCMS

Upgrade to latest OC preview in a separate branch to test System.Text.Json (OCC-245)

Open sarahelsaig opened this issue 1 year ago • 3 comments

Followup to https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/692

  • Open a task/system-text-json-migration branch from main and start your issue branch from there. After this issue is done, we won't yet merge this to main, waiting for that for OC v2.0.
  • Upgrade all OC and Lombiq packages to the appropriate 2.0 preview versions.
  • Remove all Newtonsoft.Json converters (Legacy*Converter classes), only the STJ versions should remain. If there are any types with only Newtonsoft converters, implement the missing STJ version.
  • Fix any other bugs.
  • For every general OC issue we find, open an OC issue.

Jira issue

sarahelsaig avatar May 04 '24 18:05 sarahelsaig

FYI this too @MikeAlhayek.

Piedone avatar May 04 '24 20:05 Piedone

What's up here, @sarahelsaig?

Piedone avatar Jun 10 '24 17:06 Piedone

I'm struggling with CloudSmitch package restores failing only in GHA runs (they work in local). Turns out this is not limited to NuGet publishing, for example normal build fails in NEST-536 as well (for example here)

sarahelsaig avatar Jun 13 '24 20:06 sarahelsaig

Looks like this was accidentally left open.

sarahelsaig avatar Mar 10 '25 10:03 sarahelsaig