Aerial icon indicating copy to clipboard operation
Aerial copied to clipboard

Screensave doesn't stop by any button press

Open VasilisPat opened this issue 1 year ago • 7 comments

Describe the bug Screensaver does not terminate after any keyboard or mouse press.

Expected behavior Terminate aerial on any button press, mimic Window's screensaver action.

Aerial Version Aerial v1.0.0

VasilisPat avatar Oct 07 '22 18:10 VasilisPat

Ouch. I've seen this happen once or twice on my computer after I released v1.0.0, but it doesn't happen consistently. Have you been able to consistently reproduce the error?

OrangeJedi avatar Oct 07 '22 18:10 OrangeJedi

Yes, alomst every time. The only way to exit seems to be alt+f4 or windows+d.

VasilisPat avatar Oct 07 '22 18:10 VasilisPat

I'm going to try to re-produce the error on my end. Do you have the lock computer after running setting turned on? Have you opened an Aerial preview window since the last time Aerial was started?

OrangeJedi avatar Oct 07 '22 19:10 OrangeJedi

No, the lock computer option is left disabled and preview wasn't opened.

VasilisPat avatar Oct 07 '22 19:10 VasilisPat

Okay, there was definitely an issue where if the preview windows was opened and the screensaver started up later that Aerial wouldn't quit. I added the code to fix this in the v1.0.1 branch, but I don't know if that was the specific issue. If you have a node.js environment setup you could test this yourself.

If you quit Aerial (right click on the tray icon, then restart the program) and then immediately start the screensaver via the tray menu does the issue still happen?

OrangeJedi avatar Oct 07 '22 19:10 OrangeJedi

Tried exiting the application and restarting Aerial without running preview. When the screensaver automatically kicks in, sometimes any keypress would stop the playback but other times it would act as if nothing happened. So I think that running the preview had some association with it, but there is something else too hiding underneath.

VasilisPat avatar Oct 07 '22 20:10 VasilisPat

Thanks! I fixed the preview patch in v1.0.1 and added a few small changes decrease the likelihood of this happening. Let me know if updating Aerial fixes the issue!

OrangeJedi avatar Oct 07 '22 22:10 OrangeJedi