James Howe

Results 442 comments of James Howe

👎 https://github.com/saltstack/salt/issues/62446#issuecomment-1211009983

- where is the new draft? - if this were a PR then we could leave and track comments in-line

I've not looked at everything yet, but here's first thoughts: ### Install Salt - "Salt-supported" should be hyphenated, or just say "supported" - First mention of Tiamat (in the Warning...

Any `x509.certificate_managed` state with `ca_server`, such as the documentation examples.

@th31nitiate that's a different problem, possibly #52180 This issue is about it generating new certificates (which are all saved to disk) that are never used because the current certificate doesn't...

@glynnforrest no, this issue is about it generating new certificates before it does any checks at all.

I just stopped using `copypath` to avoid the major issues with this. If submitting a complete rewrite @glynnforrest then you may also want to look at my solution to #52180

Generating new certificates you don't need, whether they stay in memory or are saved to disk, can be considered a security issue. In a strict environment, every one would need...

@sagetherage that would also be a good time to look at deduplicating between the tls and x509 states and modules.