ods-android icon indicating copy to clipboard operation
ods-android copied to clipboard

728 - Allow leading icon on OdsPasswordTextField

Open LaurentRenard opened this issue 2 years ago • 3 comments

The purpose of this PR is to add an optional leading icon to OdsPasswordTextField, similarly to OdsTextField

Without this, it is not possible to implement a properly balanced basic login form (user/password) where both fields should present a leading icon

LaurentRenard avatar Dec 08 '23 08:12 LaurentRenard

Deploy Preview for ods-android ready!

Name Link
Latest commit 4b58e7b0dc28a5b0b1f1593e3ab1aa4ab7553ec0
Latest deploy log https://app.netlify.com/sites/ods-android/deploys/6572cdf16eb95f00084b1e16
Deploy Preview https://deploy-preview-733--ods-android.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 08 '23 08:12 netlify[bot]

Hi @LaurentRenard, we saw your PR however your request requires validation from the design team. @mccart77, could you tell us if adding a leading icon in a password text field is something that we can consider?

paulinea avatar Dec 08 '23 09:12 paulinea

Hi @LaurentRenard, can we discuss the options you would like to consider, perhaps we can do this via Friends of ODS on Teams.

mccart77 avatar Dec 11 '23 14:12 mccart77