nifikop icon indicating copy to clipboard operation
nifikop copied to clipboard

Published 20 hours ago • verified publisher icon Orange-OpenSource

propagate user provided issuerRef Group

Open mh013370 opened this issue 3 years ago • 1 comments

Q A
Bug fix? yes
New feature? yes
API breaks? no
Deprecations? no
Related tickets N/A
License Apache 2.0

What's in this PR?

IssuerRef.Group references are currently not carried forward to the Certificate being created for users. If we have provided a custom IssuerRef under a non-default cert-manager group to create certs for users, it's ignoring the group and so certs are not provisioned correctly. This PR just carries forward the Group configured.

Why?

Custom Issuers or ClusterIssuers with a non-default cert-manager Group will not work with nifikop. This PR fixes that.

Additional context

Checklist

  • [x] Implementation tested
  • [x] Error handling code meets the guideline
  • [x] Logging code meets the guideline
  • [x] User guide and development docs updated (if needed)
  • [x] Append changelog with changes

mh013370 avatar Dec 06 '21 11:12 mh013370

I've fixed the build on this PR as i mimicked changes seen in fe69e9eddd7e10ed7cc8ab6aa8d9b1c1ea73d133

mh013370 avatar Feb 26 '22 16:02 mh013370