casskop icon indicating copy to clipboard operation
casskop copied to clipboard

Insecure flag for CassandraBackup

Open an-tex opened this issue 4 years ago • 6 comments

Feature Request

Is your feature request related to a problem? Please describe.

When using a self-deployed S3 solution like minio the use case arises for using insecure HTTP connections. This currently can't be configured.

Describe the solution you'd like to see https://github.com/instaclustr/icarus allows setting an "insecure: true" flag. This flag could be included in the CassandraBackup CRD which in turn passes it's value to icarus

an-tex avatar Mar 23 '21 13:03 an-tex

@an-tex what about providing a PR ? The change should be minimal, at the CRD, in the controller and a unit test to confirm it’s taken into account. That should be a parameter on both the backup and restore objects.

cscetbon avatar Mar 24 '21 12:03 cscetbon

Thanks for the directions @cscetbon . I've never done anything with go but I'll give it a shot :)

an-tex avatar Mar 25 '21 10:03 an-tex

Waiting for https://github.com/instaclustr/instaclustr-icarus-go-client/issues/3

an-tex avatar Mar 25 '21 12:03 an-tex

@an-tex It seems that PR has been merged. It might be a good time to get back to it ;)

cscetbon avatar Apr 28 '21 01:04 cscetbon

Yes but there's no package available, please have a look here https://github.com/instaclustr/instaclustr-icarus-go-client/pull/4#issuecomment-816490030 @cscetbon

an-tex avatar Apr 28 '21 07:04 an-tex

@an-tex I'm not sure why you need a package ? CassKop depends on the GitHub repo directly not on any released package, see https://github.com/Orange-OpenSource/casskop/blob/master/go.mod#L17

cscetbon avatar Jun 16 '21 01:06 cscetbon