Orange-Boosted-Bootstrap icon indicating copy to clipboard operation
Orange-Boosted-Bootstrap copied to clipboard

Docs: Add `<details><summary>` to hide design callouts

Open louismaximepiton opened this issue 10 months ago • 1 comments

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Added small CSS to handle these hidden parts. Some design callouts weren't hidden for understanding of the doc (navs&tabs, navbar, introduction, badge and so on).

Used several sentences:

  • Other Bootstrap variants when one of the examples is ok but not the other(s)
  • See Bootstrap example(s) if the example doesn't introduce any new class
  • See Bootstrap variant(s) if the example introduces a new class

Several questions to answer before merging this:

  • Is the design ok?
  • Is the information loss fine?

Motivation & Context

Following the refactoring of buttons and dropdowns. Avoid polluting the user experience.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • [x] My change follows accessibility good practices; I have at least run axe

Design

  • [x] My change respects the design guidelines defined in Orange Design System
  • [x] My change is compatible with a responsive display

Development

  • [x] My change follows the developer guide
  • [x] I have added JavaScript unit tests to cover my changes
  • [x] I have added SCSS unit tests to cover my changes

Documentation

  • [x] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • [ ] My change introduces changes to the migration guide
  • [x] My new component is well displayed in Storybook
  • [x] My new component is compatible with RTL
  • [x] Manually run BrowserStack tests
  • [x] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • [ ] Code review
  • [ ] Design review
  • [ ] A11y review

After the merge

louismaximepiton avatar Apr 23 '24 07:04 louismaximepiton

Deploy Preview for boosted ready!

Name Link
Latest commit ab28a95e18007e84bcd4d1607a9b500dd3d8ddaf
Latest deploy log https://app.netlify.com/sites/boosted/deploys/6696271cab6d1a00080c5c1e
Deploy Preview https://deploy-preview-2548--boosted.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 23 '24 08:04 netlify[bot]