Orange-Boosted-Bootstrap
Orange-Boosted-Bootstrap copied to clipboard
Example: New e-shop example
Note: This PR supersedes https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1839 which was approved in light mode only (a11y and design)
Related issues
Closes #1560
Description
Things to know before reviewing it
- The tags should wrap on 2 lines at max and have a horizontal scroll padding.
- The phone images should respect a ratio of 3/4 and have a width of 4 columns of its parent.
- Spacings between texts inside the main phone cards are 20px above, 5px between
From
and orange price and 0px between this price and the optionnal one under. - There are some issues with the font styles. They will mainly be tackled with font tokens once we implement them.
- Many spacings will need to be reworked once the spacing tokens will be implemented.
- The counter component will maybe be discussed inside a spec meeting to determine the behavior, the a11y and the different designs it could take.
- Fine to write on
.bg-danger
-
.border-supporting-*
shouldn't exist since its example related. They have been transformed into.border-success
and.border-info
. - The design for the main phone cards as been a bit tweaked to make sure to have the same (or almost) markup in each card (the checkbox and button should appear 20px under the bottomest element above).
- The stretched links should be used only if there's only one thing to handle. There should be non-cliquable elements around those.
- I've added some skip links, feel free to add some if you can see some useful others.
- I've added a back-to-top component.
- Some colors have to be tweaked a bit since the design changed some color tokens.
Things to tackle outside of this PR
- Fonts
- Issue for counter component
- Issue for color chip
- Responsive breadcrumb (#891)
- Better star rating without form markup ? (#1764)
- Checkboxes and radio buttons to size up to 20px (#1860)
- Line-through is a bit shifted on design
- Double range slider (#116)
- Better our spacer after
ul
/p
, ... with multiple of 5 ?
Saved information after the modification for the dark mode
1rst commit: https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/commit/904c7a8807025b5f4004ff57010d849148feb160 Commit with dark mode changes: https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/commit/db92da546f747355ab56c55ffd6e6fe096449572
Motivation & Context
Types of change
- New feature (non-breaking change which adds functionality)
Live previews
Checklist
Contribution
- [x] I have read the contributing guidelines
Accessibility
- [x] My change follows accessibility good practices; I have at least run axe
Design
- [x] My change respects the design guidelines defined in Orange Design System
- [x] My change is compatible with responsive display
Development
- [x] My change follows the developer guide
- (NA) I have added JavaScript unit tests to cover my changes
- (NA) I have added SCSS unit tests to cover my changes
Documentation
- [x] My change introduces changes to the documentation and/or I have updated the documentation accordingly
Checklist (for Core Team only)
- [ ] My change introduces changes to the migration guide
- (NA) My new component is added in Storybook
- (NA) My new component is compatible with RTL
- [ ] Manually run BrowserStack tests
- [ ] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
- [ ] Code review
- [ ] Design review
- [ ] A11y review
After the merge
- [ ] Manually launch Percy tests
Deploy Preview for boosted ready!
Name | Link |
---|---|
Latest commit | 4e335a883718517494b61c605eb063d180b6e05b |
Latest deploy log | https://app.netlify.com/sites/boosted/deploys/65b8a69e410fa100085fcf18 |
Deploy Preview | https://deploy-preview-2434--boosted.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The mode selector should be in the header. The dark mode version should be provided by the designers.