Orace
Orace
What if the input is not sorted? Does the fact that the input is sorted is relevant? As an example, consider: `[0, 0, 2, 2, 1, 1]` I propose: 1....
> It's important that the source is "sorted" in the sense that identical values are adjacent, otherwise the result will not be correct. It's important for a use case of...
To improve the documentation, we may get a lesson from [System.Linq.Enumerable.Zip](https://docs.microsoft.com/en-us/dotnet/api/system.linq.enumerable.zip) method.
This is related to #670
Why not a 0-based `FindIndices`, a plural version of the existing `List.FindIndex` ? Or `IndicesWhere` with a predicate ?
https://github.com/morelinq/MoreLINQ/blob/b839848e83597e0c7698290ac416354c27160003/MoreLinq/ToHashSet.cs#L17-L19 This test is at compile time, not at use time. You can compile with 4.7 and still have the issue. Maybe you can look what as been done in...
> > This test is at compile time, not at use time. > > Not sure what you mean by this. This flag is meant to prevent inclusion of the...
> I have wondered why this solution isn't used before The cons I see : - Hard to maintain. - Many more target frameworks. - Need a quick new release...
In unit testing pattern we should not even use TestingSequence since it tests multiple things. (Enumerator disposal, multiple enumeration, multiple MoveNext at the end of the source). I'm agree that...
Anyway the current implementation is not really optimal (intermediate object creation, test for null, etc...) For performance reason, I think that the MoreLinq methods should not call other MoreLinq methods...