Alex Rudenko

feat!: remove PUPPETEER_DOWNLOAD_PATH in favor of PUPPETEER_CACHE_DIR

1

To migrate: use PUPPETEER_CACHE_DIR/cacheDirectory instead of PUPPETEER_DOWNLOAD_PATH/downloadPath. Closes https://github.com/puppeteer/puppeteer/issues/10164

"Target should not report uninitialized pages" does not make sense for BiDi

2

In CDP we checked that target cannot be changed during initialization. In bidi, there is no initialization step that is needed so the target is changed whenever the context is...

"[target.spec] Target should not crash while redirecting if original request was missed" is flaky in Chrome BiDi

3

See https://github.com/puppeteer/puppeteer/actions/runs/6455880162/job/17525033054?pr=11099 ``` 20) Target should not crash while redirecting if original request was missed: TimeoutError: Waiting for load event timed out. at Timeout. (packages/puppeteer-core/src/util/Deferred.ts:34:25) at listOnTimeout (node:internal/timers:569:17) at processTimers...

`captureBeyondViewport` does not work in v21.6.1

2

It worked in 21.4.1 See https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_dbg_fastbuild/b8760472979767066721/overview for the screenshot diffs and affected tests.

Fix ng-schematics release-please

1

Somehow the release please config was not updated so it resulted in duplicate releases https://github.com/puppeteer/puppeteer/pull/11508

Screenshot tests are flaky/failing after M120 roll

2

See for the tests that have been affected: https://github.com/puppeteer/puppeteer/pull/11501/files @jrandolf could you please take a look as well as at the user reported bugs?

We regressed in the following scenario somewhere along the refactorings probably due to lazy arguments and lazy context: ``` const result = page.evaluate(() => { return new Promise(resolve => {...

Upgrade the mime package

1

Version 4.0.0 has breaking changes https://github.com/broofa/mime/blob/main/CHANGELOG.md In particular, no CJS support. We need to upgrade and run `@dependabot unignore mime` once done. cc @jrandolf @Lightning00Blade

cosmiconfig has a breaking change that requires defining the strategy for the config search https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#900 We need to upgrade and test the upgrade manually. We then need to run `@dependabot...

Flaky Test - `Error: Browser was not set-up in time!`

2

Happens in the flaky manner: https://github.com/puppeteer/puppeteer/actions/runs/7046304099/job/19177866980?pr=11471#step:13:906 cc @jrandolf @Lightning00Blade