OrJDev

Results 46 comments of OrJDev

> To me its still unclear what > ```ts > f > .maxSize("64MB") > .fileCount(2, "max") > ``` > will do. > > On one hand the missing `File` in...

Updated the pr, it now looks like: ```ts // FileRouter for your app, can contain multiple FileRoutes export const ourFileRouter = { // Define as many FileRoutes as you like,...

Not sure why deployment is failing, can anyone with access tell me the error?

> I personally don't like the "max 2 files of 1gb each" part. I assume it has type-safety but this would be harder to create and/or reuse by other functions....

> You should rename `genereateReactComponents` to `generateReactComponents`, the word generate is misspelled. Thank you, fixed that and also implemented this function for solid

This also allows the url to be passed at first and then used in all of the solid's adapter functions instead of having to pass it everytime: ```tsx import {...

> One last thing on naming. If I'm bringing in `createSolidComponents` from a package named `@uploadthing/solid` then the `Solid` is implied. Perhaps `createComponents` in both cases? > > > >...

> 👍🏼 > > left some docs notes Resolved everything.

> don't see a real issue here since you can just remove the empty array if you're not extending anything. obviously open for a fix if anyone wants to spend...