MCAntiMalware icon indicating copy to clipboard operation
MCAntiMalware copied to clipboard

[FEATURE REQUEST] Optimizing

Open OpticFusion1 opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Program uses a lot of CPU, Memory, and Power Usage. This should be optimized as much as possible.

Describe the solution you'd like N/A

Describe alternatives you've considered N/A

Additional context N/A

OpticFusion1 avatar May 20 '21 03:05 OpticFusion1

JVM options could help as well. Figuring out what options should be used though would take time

OpticFusion1 avatar May 21 '21 16:05 OpticFusion1

It's possible there's a memory leak or something actually, not sure where it would be though

OpticFusion1 avatar Jun 02 '21 06:06 OpticFusion1

Looked through the code too see if there's anything that could be optimized. "walkThroughFiles" which is part of the check code gets called a lot (200+ times), this should be moved to the Scanner class and each check be process(ClassNode, CacheContainer) insteadd if possible.

OpticFusion1 avatar Jun 15 '21 12:06 OpticFusion1

Definitely either a memory leak, or stuffs not being GC'd properly

OpticFusion1 avatar Jun 22 '21 08:06 OpticFusion1

Commits e6e6c4b9c77b9ba18cb81009c924aee5d974299d and 6fa2f0971dc790be01e56eb74c2873d86c006616 should optimize the program a bit more, however I'm sure it can be further optimized

OpticFusion1 avatar Sep 25 '21 02:09 OpticFusion1