Mario Rugiero

> For example we need to keep track of what to free in the malloc failure case. What do you mean here? Possible temporaries aside from the `roaring64` instance? I...

I think it should at least be a global decision, and a documented one, given we don't always use the system allocator. If we opt to assume allocations can't fail...

It doesn't necessarily have to be one or the other though, it can be two different flags. On my use case we don't fill the disk, but the amount of...

Flagged it `pipelines` because adding tests doesn't merit a changelog update. We should use a different, more explicit flag for that, tho.

> It seems that pedersen is just a very expensive operation. This has been the case for cairo-rs as well, so it checks out. That said, I believe we can...

> Command Mean [s] Min [s] Max [s] Relative > `base set_integration_benchmark` 1.850 ± 0.005 1.845 1.858 1.00 > `head set_integration_benchmark` 2.064 ± 0.006 2.053 2.076 1.12 ± 0.00 F

Suggestion: the canonical way to do this is with doc comments (the triple `/`) in the source code. It's able to include and compile examples as well. A more "tutorial-like"...

> * Two lines in `vm/src/lib.rs` and `vm/src/vm/runners/cairo_pie.rs` pessimistically assume `wasm no_std`, when the former works just fine - we can be more precise. Those really shouldn't be handled there...

> I'm not sure if this means I need to update the PR or if it's a general comment, could you clarify ? Just a general comment. Your fix for...

> Should I add this as a fix to the changelog? The PR template wasn't clear on this (this isn't a change that needs to be 'documented', per se). Just...