opla-v2
opla-v2 copied to clipboard
BUILDER> Editing intent's name in the intent admin not working
CURRENTLY :
Editing intent's name directly in intent is not working
It should be an inline edit, as in dashboard.

@arnaud-moncel, @damien-citaire After digging, https://github.com/Opla/opla/blob/2928bfd4fca32037dec2949cd81ee5835f3b2eb8/front/src/shared/containers/builder/intentContainer.jsx#L431 should be replaced by a TextField, especially if we want the same behaviour between dashboard page and builder page.
We're actually facing an issue. Current rename behavior on the left panel (Intent section) should not be modified: since single click on an intent actually display it on the center panel, click-to-edit shouldn't be used. That implies that Zrmc.showDialog
should be kept on the left menu. In order to avoid different behavior for the same feature, we suggest implementing the same behavior from the left column.
Ok, thanks.
{name}
is from
https://github.com/Opla/opla/blob/2928bfd4fca32037dec2949cd81ee5835f3b2eb8/front/src/shared/containers/builder/intentContainer.jsx#L403-L407
and intent.name
from
https://github.com/Opla/opla/blob/2928bfd4fca32037dec2949cd81ee5835f3b2eb8/front/src/shared/containers/builder/intentContainer.jsx#L396
It's look like it's state dependent. Maybe we can store the editing version in state, en sync it with the redux store on Save click or focus out ? What do you think ?
We can make that. But as we said it in the previous message, it would give two different behavior for the same feature. Wouldn't it be better to put the behavior of the left column in center column in a view of harmonization?
Thanks Damien, In the future the possibility to edit the intent name from the intent list on the left (via a dialog) will be removed, and intent will be only editable from its details view displayed inside the center panel. The left pannel with intent list is in active developpement right now, removing the editing on this part will be another issue.
To sum up we want to add inline editing for the intent name in center panel (intent ), and remove the dialog editing later.
We still have issues while trying to edit first intent's name.
Pencil obviously not working.