front-end
front-end copied to clipboard
Converted all the css into Tailwind css of Container component
Description of changes
Converted all the css into Tailwind css of Container component Issue - #1725
Issue Resolved
Fixes #NA
Screenshots/GIFs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
operation-code | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 14, 2023 6:06am |
storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 14, 2023 6:06am |
2 flaky tests on run #4529 ↗︎
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind | |||
Project: operation_code | Commit: 4c30d24528 |
||
Status: Passed | Duration: 03:10 💡 | ||
Started: Nov 14, 2023 6:07 AM | Ended: Nov 14, 2023 6:10 AM |
hashlink.spec.js • 1 flaky test • all tests
Test | Artifacts | |
---|---|---|
Hash Links > on About page > will change route when clicked |
Screenshots
Video
|
modal.spec.js • 1 flaky test • all tests
Test | Artifacts | |
---|---|---|
when the server responds successfully > closes the modal when the x button is clicked |
Screenshots
Video
|
Review all test suite changes for PR #1746 ↗︎
hey @kylemh any further changes needed?
Yes. If you look into the status checks of this PR, you'll see that tests are failing. You'll want to fix those failures.
Additionally, you should do some due dilligence by running the dev server and comparing betwen production and your local branch. I see that background color is incorrect on https://operation-code-r4usxeoc6-operation-code.vercel.app/#join-our-thriving-community-link (see baseline). Also note that the About page's hero's background image is out of position when compared to prod.
These are just two of potentially multiple issues that you'll want to investigate and resolve.
Yes. If you look into the status checks of this PR, you'll see that tests are failing. You'll want to fix those failures.
Additionally, you should do some due dilligence by running the dev server and comparing betwen production and your local branch. I see that background color is incorrect on https://operation-code-r4usxeoc6-operation-code.vercel.app/#join-our-thriving-community-link (see baseline). Also note that the About page's hero's background image is out of position when compared to prod.
These are just two of potentially multiple issues that you'll want to investigate and resolve.
Okay will check that
hey @kylemh sorry for the delay, I am a bit confused, can you help out?
Not for awhile, but maybe you can pause here and try converting another component? Please share which component you plan on doing in #1725 before doing it so you dont step on somebody else's feet!
Code Climate has analyzed commit 4c30d245 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (90% is the threshold).
This pull request will bring the total coverage in the repository to 75.6% (0.0% change).
View more on Code Climate.