front-end icon indicating copy to clipboard operation
front-end copied to clipboard

Converted all the css into Tailwind css of Container component

Open subhajit20 opened this issue 1 year ago • 8 comments

Description of changes

Converted all the css into Tailwind css of Container component Issue - #1725

Issue Resolved

Fixes #NA

Screenshots/GIFs

subhajit20 avatar Sep 29 '23 05:09 subhajit20

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 6:06am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 6:06am

vercel[bot] avatar Sep 29 '23 05:09 vercel[bot]

2 flaky tests on run #4529 ↗︎

0 35 0 0 Flakiness 2

Details:

Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind
Project: operation_code Commit: 4c30d24528
Status: Passed Duration: 03:10 💡
Started: Nov 14, 2023 6:07 AM Ended: Nov 14, 2023 6:10 AM
Flakiness  hashlink.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
Hash Links > on About page > will change route when clicked Screenshots Video
Flakiness  modal.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Screenshots Video

Review all test suite changes for PR #1746 ↗︎

cypress[bot] avatar Sep 29 '23 05:09 cypress[bot]

hey @kylemh any further changes needed?

subhajit20 avatar Oct 11 '23 04:10 subhajit20

Yes. If you look into the status checks of this PR, you'll see that tests are failing. You'll want to fix those failures.

Additionally, you should do some due dilligence by running the dev server and comparing betwen production and your local branch. I see that background color is incorrect on https://operation-code-r4usxeoc6-operation-code.vercel.app/#join-our-thriving-community-link (see baseline). Also note that the About page's hero's background image is out of position when compared to prod.

These are just two of potentially multiple issues that you'll want to investigate and resolve.

kylemh avatar Oct 11 '23 13:10 kylemh

Yes. If you look into the status checks of this PR, you'll see that tests are failing. You'll want to fix those failures.

Additionally, you should do some due dilligence by running the dev server and comparing betwen production and your local branch. I see that background color is incorrect on https://operation-code-r4usxeoc6-operation-code.vercel.app/#join-our-thriving-community-link (see baseline). Also note that the About page's hero's background image is out of position when compared to prod.

These are just two of potentially multiple issues that you'll want to investigate and resolve.

Okay will check that

subhajit20 avatar Oct 11 '23 14:10 subhajit20

hey @kylemh sorry for the delay, I am a bit confused, can you help out?

subhajit20 avatar Oct 30 '23 15:10 subhajit20

Not for awhile, but maybe you can pause here and try converting another component? Please share which component you plan on doing in #1725 before doing it so you dont step on somebody else's feet!

kylemh avatar Oct 30 '23 16:10 kylemh

Code Climate has analyzed commit 4c30d245 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Nov 14 '23 06:11 codeclimate[bot]