opentrons
opentrons copied to clipboard
refactor(app,api): Add an "awaiting-recovery" run status
Overview
Closes EXEC-299.
Changelog
- Set up our types for a new
awaiting-recovery
run status. It's not actually used by Protocol Engine or emitted by robot-server yet. See the Python docstring for the semantics that we have in mind so far. - Attempt to update the many little bits of logic in the app that use the run status.
Test plan
There's nothing substantial to test here yet because the new status isn't used by Protocol Engine or emitted by robot-server yet.
I've deliberately omitted unit tests because I think, at this stage, we want to keep it cheap to fundamentally rework the semantics of this status. But I'm happy to go back and add them if anyone thinks they'd be helpful.
Review requests
Any questions or suggestions about the semantics of this new status?
Risk assessment
Low until this new status actually gets emitted.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.34%. Comparing base (
f307641
) to head (3d7ec4f
). Report is 3 commits behind head on edge.
Additional details and impacted files
@@ Coverage Diff @@
## edge #14651 +/- ##
==========================================
- Coverage 67.34% 67.34% -0.01%
==========================================
Files 2485 2485
Lines 71439 71438 -1
Branches 9057 9056 -1
==========================================
- Hits 48114 48113 -1
Misses 21173 21173
Partials 2152 2152
Flag | Coverage Δ | |
---|---|---|
g-code-testing | 92.43% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
...pi/src/opentrons/protocol_engine/state/commands.py | 99.44% <ø> (ø) |
|
api/src/opentrons/protocol_engine/types.py | 97.50% <ø> (ø) |
|
...rganisms/Devices/ProtocolRun/ProtocolRunHeader.tsx | 88.12% <ø> (ø) |
|
...rc/organisms/Devices/hooks/useLastRunCommandKey.ts | 22.22% <ø> (ø) |
|
app/src/organisms/Devices/hooks/useRunStatuses.ts | 100.00% <ø> (ø) |