opentrons icon indicating copy to clipboard operation
opentrons copied to clipboard

feat(app): add test and stories for Tooltip

Open koji opened this issue 2 years ago • 2 comments

Overview

This PR will add test cases for Tooltip fix RAUT-130

Changelog

  • add test for Tooltip
  • add stories for Tooltip

Review requests

  • [ ] test cases cover basic stuff
  • [ ] When running Storybook, you can see 2 items under Tooltip and they work as expected

Risk assessment

low

koji avatar Aug 11 '22 22:08 koji

Codecov Report

Merging #11333 (869b242) into edge (398ee3c) will increase coverage by 0.15%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11333      +/-   ##
==========================================
+ Coverage   74.48%   74.64%   +0.15%     
==========================================
  Files        2045     2050       +5     
  Lines       56889    57452     +563     
  Branches     5530     5706     +176     
==========================================
+ Hits        42374    42885     +511     
- Misses      13283    13294      +11     
- Partials     1232     1273      +41     
Flag Coverage Δ
app 74.72% <0.00%> (+0.75%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/atoms/Tooltip/Tooltip.stories.tsx 0.00% <0.00%> (ø)
app-shell/src/dialogs/index.ts 88.88% <0.00%> (-11.12%) :arrow_down:
app-shell/src/protocol-analysis/index.ts 93.75% <0.00%> (-6.25%) :arrow_down:
app/src/redux/config/actions.ts 75.75% <0.00%> (-4.25%) :arrow_down:
...colRun/SetupLiquids/LiquidsLabwareDetailsModal.tsx 81.08% <0.00%> (-2.79%) :arrow_down:
app/src/redux/config/selectors.ts 79.16% <0.00%> (-2.66%) :arrow_down:
app/src/redux/discovery/selectors.ts 93.65% <0.00%> (-1.52%) :arrow_down:
app/src/organisms/Devices/RobotStatusBanner.tsx 76.47% <0.00%> (-1.31%) :arrow_down:
app-shell/src/config/migrate.ts 90.76% <0.00%> (-0.90%) :arrow_down:
app/src/redux/pipettes/selectors.ts 84.66% <0.00%> (-0.64%) :arrow_down:
... and 24 more

codecov[bot] avatar Aug 11 '22 22:08 codecov[bot]

  • [x] make Tooltip stories work
    • [x] when hovering a button
    • [x] when clicking a button

koji avatar Aug 12 '22 04:08 koji

  • [x] address pr comment

koji avatar Aug 16 '22 14:08 koji