opentrons icon indicating copy to clipboard operation
opentrons copied to clipboard

refactor(app): consolidate overflow menu logic

Open koji opened this issue 2 years ago • 1 comments

Overview

This will close #11009

Changelog

  • remove hardcoded value from width
  • improve typing when using useOnClickOutside

Review requests

  • [ ] overflow menu shows items without wrapping their text
  • [ ] overflow menu works as well as before updating

Risk assessment

low

koji avatar Aug 04 '22 19:08 koji

Codecov Report

Merging #11293 (15302c6) into edge (4e24c16) will increase coverage by 0.11%. The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11293      +/-   ##
==========================================
+ Coverage   74.37%   74.48%   +0.11%     
==========================================
  Files        2040     2070      +30     
  Lines       56770    58548    +1778     
  Branches     5524     6132     +608     
==========================================
+ Hits        42221    43611    +1390     
- Misses      13326    13578     +252     
- Partials     1223     1359     +136     
Flag Coverage Δ
app 74.12% <100.00%> (+0.40%) :arrow_up:
components 53.05% <0.00%> (-0.21%) :arrow_down:
labware-library 49.74% <ø> (ø)
protocol-designer 45.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...isms/Devices/HistoricalProtocolRunOverflowMenu.tsx 80.00% <ø> (ø)
...anisms/Devices/PipetteCard/PipetteOverflowMenu.tsx 100.00% <ø> (ø)
app/src/organisms/Devices/RobotOverflowMenu.tsx 88.57% <ø> (ø)
...rc/organisms/Devices/RobotOverviewOverflowMenu.tsx 91.17% <ø> (ø)
...ganisms/ProtocolDetails/ProtocolLabwareDetails.tsx 70.37% <ø> (ø)
...pp/src/organisms/ProtocolsLanding/ProtocolList.tsx 78.12% <ø> (ø)
...nts/src/interaction-enhancers/useOnClickOutside.ts 7.14% <0.00%> (ø)
app/src/atoms/MenuList/hooks.tsx 75.00% <100.00%> (ø)
app/src/organisms/Devices/PipetteCard/index.tsx 57.27% <100.00%> (-1.82%) :arrow_down:
.../RobotSettings/CalibrationDetails/OverflowMenu.tsx 72.28% <100.00%> (-1.40%) :arrow_down:
... and 142 more

codecov[bot] avatar Aug 04 '22 19:08 codecov[bot]