Minion Dmg/ias while affected by a herald does not work

[patrick-solving-problems]

Hi,

I have a Harold of Agony and some items with

“Minions have XX% increased Attack and Cast Speed while you are affected by a Herald” or “Minions have XX% increased Damage while you are affected by a Herald”

both do not increase my DPS. Harold of Agony is active in my skills tab, so PoB should be able to calculate correctly.

Can this be fixed, or should I even try to fix it myself? (I am a professional software developer, but not familiar with this project and the coding language)

[johnsixteen]

I can confirm this issue. There isn't any sort of "Are you affected by a herald?" option in the configurations, or even the assumption that you are if you have a herald gem active.

In my particular situation I am using Herald of Agony, and things like the Lone Messenger unique small cluster, or any medium "while affected by a herald) cluster has no increase to dps. The tree view does show the damage components, but red (aka: ignored) which means they are at least represented.

Here are some other issues I've noticed as well...

1. +1 to Level of all Chaos Spell Skill gems on an amulet does not apply to Herald of Agony gem (it should).
2. The "Are your minions always on Full Life" option in the Configuration section doesn't actually do anything.
3. damage represented by "# of Virulence Stacks" is hard coded to cap at 40, even though you can get 45-50+ depending on multiple medium cluster jewels.

What it seems like to me is that when cluster jewels were added, a lot of these details were not flushed out. Hopefully this is something that eventually gets some attention, otherwise PoB will just be mostly useless for certain builds.