polkadot-runtime-template icon indicating copy to clipboard operation
polkadot-runtime-template copied to clipboard

Upgrade generic-template to polkadot-stable2503

Open 4meta5 opened this issue 10 months ago • 1 comments

WIP Closes #411

Repo/Forks to Upgrade

TODO

  • [ ] (WIP) runtime compilation
  • [ ] node compilation
  • [ ] CI green

4meta5 avatar May 12 '25 15:05 4meta5

Deploy Preview for docs-oz-polkadot canceled.

Name Link
Latest commit b336c012749630a4cb0feeabd1f1290165ae81a9
Latest deploy log https://app.netlify.com/projects/docs-oz-polkadot/deploys/685c18957aeaca00072fdafa

netlify[bot] avatar May 12 '25 15:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (9875363) to head (b336c01). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...template/runtime/src/configs/governance/origins.rs 0.00% 11 Missing :warning:
...neric-template/runtime/src/configs/asset_config.rs 0.00% 3 Missing :warning:
generic-template/runtime/src/configs/xcm_config.rs 0.00% 2 Missing :warning:
generic-template/runtime/src/types.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   78.88%   78.54%   -0.34%     
==========================================
  Files          17       17              
  Lines        2145     2153       +8     
  Branches     2145     2153       +8     
==========================================
- Hits         1692     1691       -1     
- Misses        390      399       +9     
  Partials       63       63              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 23 '25 18:06 codecov[bot]

The coverage generation is indicating that more coverage needs to be added but the added lines come from the new requirement to derive DecodeWithMemTracking for all structs stored in storage which led to the derive annotation being too long to fit in one line. So I do not think it is really necessary or valuable to add tests for that specific change. I'm not sure what tests would be added anyway to satisfy the line split.

@KitHat let me know your thoughts on this, I do not think the coverage generation passing is a requirement for merging.

4meta5 avatar Jun 25 '25 14:06 4meta5