polkadot-runtime-template icon indicating copy to clipboard operation
polkadot-runtime-template copied to clipboard

🏗️ [Core Feature]: Tracing

Open 4meta5 opened this issue 1 year ago • 5 comments

What is the key feature we're aiming to implement?

Tracing is an important feature for developer testing. It is not fully included by Frontier in its current state, but Acala and Moonbeam each have their own custom implementation that may be used as a reference. Ideally, an implementation is upstreamed into Frontier before being included in this repo.

Contribution Guidelines

  • [x] I agree to follow this project's Contribution Guidelines

4meta5 avatar Mar 26 '24 13:03 4meta5

After internal discussion, we evaluated that this issue is not does not have huge impact, and also will pollute the template and complicate it a lot. Thus, the value brought by this issue simply does not outweigh the cons.

ozgunozerk avatar Jun 24 '24 09:06 ozgunozerk

I do not think this should be closed if not completed. Moving to backlog and deprioritizing is more appropriate. I'm personally happy to take this issue in the future once we come around to how useful is is. Better to do that than delete it and treat it as finished when it is not...

4meta5 avatar Jun 24 '24 11:06 4meta5

Internal decision was to abandon this due to the reasons I explained above. If I'm recalling these wrong, happy to discuss that in a meeting as well. We had to duplicate many things in our template due to tracing and the template was going to be convoluted.

Closing the issue is not deleting it, we can always re-open it if things change (i.e. if frontier includes tracing, so we can just import it to our template rather than convoluting our template). From our meetings, I remember that we decided NOT to do this and forgo it.

ozgunozerk avatar Jun 24 '24 12:06 ozgunozerk

Why would we close as completed if the issue was not completed?

I made this issue and would prefer that it's moved to the backlog if it's not done because I think it's still worth tracking.

From our meetings, I remember that we decided NOT to do this and forgo it.

I remember your justification for not doing it for this milestone, but I do NOT remember agreeing that it should never be done.

4meta5 avatar Jun 24 '24 12:06 4meta5

Sure, it's just better if we can do these discussions in a meeting, usually much more productive. We can decide what to do with this issue. I'm perfectly fine putting the tag on hold to this, and then waiting for frontier to implement it, or help them implement it, then import the tracing feature from upstream to our template. If disagreed or have other opinions, let's discuss them in the upcoming meeting 👍

ozgunozerk avatar Jun 24 '24 12:06 ozgunozerk