openzeppelin-upgrades icon indicating copy to clipboard operation
openzeppelin-upgrades copied to clipboard

add option to return populated upgrade transaction

Open thegostep opened this issue 5 years ago • 3 comments

Returning a populated upgrade transaction would allow me to craft and send the transaction through a multisig instead of the buidler signer

thegostep avatar Sep 21 '20 13:09 thegostep

Hi @thegostep! Thanks for the suggestion, it is really appreciated.

The project owner will review your suggestion as soon as they can.

Please wait until we have discussed this idea before writing any code or submitting a Pull Request, so we can go through the design beforehand. We don’t want you to waste your time!

abcoathup avatar Sep 25 '20 05:09 abcoathup

I see how this could be useful. We built prepareUpgrade with this in mind but we could have gone the extra mile and returned the transaction instead of just the implementation address. I can see this being even more useful in the future if we support alternative proxy implementations/interfaces.

It would be a breaking change to change prepareUpgrade's return value in that way but we could add an option.

frangio avatar Oct 01 '20 22:10 frangio

it would also be great that this support is available the deployProxy and not only the prepareUpgrade. Is there anyway of doing this @frangio ?

FredCoen avatar Jul 25 '22 09:07 FredCoen