openzeppelin-test-helpers icon indicating copy to clipboard operation
openzeppelin-test-helpers copied to clipboard

time documentation lacks unit for return values

Open miohtama opened this issue 5 years ago • 1 comments

The time API functions are documented here https://docs.openzeppelin.com/test-helpers/0.5/api#time

However there is no proper definition of what units and types these functions return

  • String vs. int vs. big num
  • Seconds vs. milliseconds
  • Epoch

miohtama avatar Mar 29 '20 13:03 miohtama

Hi @miohtama! Thanks for the suggestion, it is really appreciated.

The project owner should review your suggestion during the next week.

Please wait until we have discussed this idea before writing any code or submitting a Pull Request, so we can go through the design beforehand. We don’t want you to waste your time!

abcoathup avatar Mar 31 '20 07:03 abcoathup