openzeppelin-test-environment icon indicating copy to clipboard operation
openzeppelin-test-environment copied to clipboard

Instead of bundling web3 as a dependency, make it a peerDependency

Open petejkim opened this issue 5 years ago • 1 comments

Instead of bundling web3 as a dependency, make it a peerDependency, so that the user of this library can provide a compatible package on their own, instead of having multiple versions of web3 in their project.

Context: I had to use a later version of 1.2.x due to a bug and I had to force the version by using "resolutions" in package.json.

Also, please remove @types/web3 - it's no longer needed as web3 comes with typescript definitions built in.

Thanks for providing this awesome project.

petejkim avatar May 15 '20 02:05 petejkim

Hi @petejkim !

Thanks for the suggestion, it is really appreciated.

The project owner should review your suggestion during the next week.

Please wait until we have discussed this idea before writing any code or submitting a Pull Request, so we can go through the design beforehand. We don’t want you to waste your time!

abcoathup avatar May 15 '20 03:05 abcoathup