openzeppelin-labs icon indicating copy to clipboard operation
openzeppelin-labs copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

Unify naming for logic contract in all projects

Open maraoz opened this issue 7 years ago • 4 comments

We use various different names for the same concept:

  • implementation contract
  • behavior contract
  • logic contract

all of these refer to the contract the proxy delegates calls to. Unify naming in all repos. Also check and update posts in https://blog.zeppelinos.org/

My personal preference among these 3 names is "behavior".

maraoz avatar Apr 20 '18 18:04 maraoz

-1 to behavior, I'd prefer implementation or backing implementation

spalladino avatar Apr 24 '18 13:04 spalladino

Decided for "logic contract", from Elena's post. Will move forward replacing all occurrences.

maraoz avatar May 21 '18 20:05 maraoz

Just discussed this offline with @leanthebean, and we decided to only use the term "logic contract" in the context of talking about proxies. All other references (i.e in the cli help, and introductory guides) should be just "contracts" to avoid unnecessary confusion.

maraoz avatar May 22 '18 15:05 maraoz

Implemented in user-facing texts on cli in https://github.com/zeppelinos/zos-cli/pull/215. Moving the issue to next milestone to refactor internal naming too (didn't want to change API so close to releasing)

maraoz avatar May 22 '18 21:05 maraoz