openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Add IERC6909ContentURI Detection to ERC6909ContentURI

Open maradini77 opened this issue 1 month ago • 2 comments

Description

  • declare support for IERC6909ContentURI in ERC6909ContentURI so clients can detect the extension via supportsInterface
  • attempted to run npm run test -- test/token/ERC6909/extensions/ERC6909ContentURI.test.js, but Hardhat aborted with HH19 (“project is ESM, rename config to .cjs”).

maradini77 avatar Nov 27 '25 14:11 maradini77

⚠️ No Changeset found

Latest commit: 580b1c6945bd0316dd0959edc8b23357aaf0e0ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 27 '25 14:11 changeset-bot[bot]

Walkthrough

A public override supportsInterface function was added to the ERC6909ContentURI contract. This function returns true when the provided interface ID matches the IERC6909ContentURI interface identifier, and delegates to the parent's supportsInterface implementation for other cases. The addition extends interface support signaling for the Content URI extension while maintaining existing functionality.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding interface detection for IERC6909ContentURI in the ERC6909ContentURI contract via supportsInterface.
Description check ✅ Passed The description is directly related to the changeset, explaining both the purpose (declaring support for IERC6909ContentURI) and noting a testing issue encountered.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

[!TIP]

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 27 '25 14:11 coderabbitai[bot]