Add `equal` to Bytes.sol and update pragma to 0.8.24 in String dependencies
In #5725, we're moving the equal function from Strings to Bytes.sol for convenience, that'd require updating the pragma of Strings's dependencies to 0.8.24 since mcopy is needed.
PR Checklist
- [ ] Tests
- [ ] Documentation
- [ ] Changeset entry (run
npx changeset add)
🦋 Changeset detected
Latest commit: cf297b15790b7884a700834ea5d66e030410740b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| openzeppelin-solidity | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Where is mcopy used ? the pragma checking scripts says Strings is fine in 0.8.20.
Where is mcopy used ? the pragma checking scripts says Strings is fine in 0.8.20.
The description is pretty clear about where's used: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5725/files#diff-e402541b45f70ec8d3de9b9f87542d9eb52920601ac011a340e723c5b4b9d659R136
I generally split the PRs because then they are too big to review, but then done individually lose context...
So this PR changes all pragma, and increass the requirements on many file, to prepare for a change in the code that is NOT in this PR, and that we are not even sure of doing in the near future ?
I would say no to that kind of change. I'd even consider not adding Strings.equal considering all the breaking pragma and the limited upside.
Include the equal function from #5725 as discussed