openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

ERC-7786 interfaces and receiver

Open Amxx opened this issue 1 year ago • 3 comments

Depends on #5252

ERC PR

NOTE

Bytes.slice uses mcopy that was introduced in 0.8.25. This requirement extends to the CAIP2 and CAIP10 library

PR Checklist

  • [x] Tests
  • [x] Documentation
  • [x] Changeset entry (run npx changeset add)

Amxx avatar Oct 14 '24 15:10 Amxx

🦋 Changeset detected

Latest commit: 1aea26e317357e072b57c416ecd2ffb6fcee5f90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 14 '24 15:10 changeset-bot[bot]

Bytes.slice is using mcopy in assembly so it works on 0.8.24, so want to confirm that we are upgrading to 0.8.25 for mcopy in code generation

cairoeth avatar Oct 16 '24 15:10 cairoeth

Bytes.slice is using mcopy in assembly so it works on 0.8.24, so want to confirm that we are upgrading to 0.8.25 for mcopy in code generation

Right, I misread the changelog, will go back to 0.8.24 for Bytes and all the code that depends on it directly or indirectly.

Amxx avatar Oct 16 '24 17:10 Amxx

Because the discussion on the PR is still quite active, we (@frangio and I) decided to remove that from the main repo in 5.2. This will go in the community repo, where it will be more "fluid".

Basically, we don't want to publish helpers that we know will be outdated in a few weeks.

Amxx avatar Oct 22 '24 15:10 Amxx