openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Implement ERC-7540

Open Amxx opened this issue 1 year ago • 7 comments

ERC-7540 is in the review phase, and looks like a good candidate for inclusion.

Amxx avatar Nov 27 '23 14:11 Amxx

@Amxx I'd love to help with this

mw2000 avatar Dec 01 '23 12:12 mw2000

Added a Draft PR https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4776

I'm still unsure about how to approach overriding deposit, redeem, withdraw, and mint functions.

mw2000 avatar Dec 01 '23 13:12 mw2000

I'm still unsure about how to approach overriding deposit, redeem, withdraw, and mint functions.

This is exactly why this issue needs to be discussed and researched BEFORE we make any PR. As the tag shows, this is this only an idea. We may not even do that at all.

One thing we need to figure out is the process for going from pendingDepositRequest to maxDeposit. Because the deposit function should consume the maxDeposit, NOT the pendingDepositRequest.

Please do not rush to propose implementations. The ERC is still in draft, and we need to hear from (multiple) potential users before we start designing an actual solution.

Amxx avatar Dec 01 '23 13:12 Amxx

Any updates on this? Superform.xyz is a cross-chain yield marketplace building on top of ERC4626 standards and now ERC7540 for asynchronous vaults. We could use a reference implementation from OpenZeppelin

0xTimepunk avatar Apr 09 '24 17:04 0xTimepunk

@Amxx @0xTimepunk more than happy to pickup where we left off on this PR, once we have designs mapped out.

mw2000 avatar Apr 12 '24 04:04 mw2000

The ERC was finalized two days ago 🎉

Screenshot 2024-06-28 at 12 37 48 PM

cc @Joeysantoro

alphastorm avatar Jun 28 '24 16:06 alphastorm

@alphastorm @Joeysantoro @mw2000 I am very interested in a reference implementation for this which composes with the rest of the OpenZeppelin ERC20/4626 lifecycle hooks

yorhodes avatar Jun 28 '24 21:06 yorhodes