openzeppelin-contracts
openzeppelin-contracts copied to clipboard
Implement ERC-7540
ERC-7540 is in the review phase, and looks like a good candidate for inclusion.
@Amxx I'd love to help with this
Added a Draft PR https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4776
I'm still unsure about how to approach overriding deposit, redeem, withdraw, and mint functions.
I'm still unsure about how to approach overriding deposit, redeem, withdraw, and mint functions.
This is exactly why this issue needs to be discussed and researched BEFORE we make any PR. As the tag shows, this is this only an idea. We may not even do that at all.
One thing we need to figure out is the process for going from pendingDepositRequest
to maxDeposit
. Because the deposit
function should consume the maxDeposit
, NOT the pendingDepositRequest
.
Please do not rush to propose implementations. The ERC is still in draft, and we need to hear from (multiple) potential users before we start designing an actual solution.
Any updates on this? Superform.xyz is a cross-chain yield marketplace building on top of ERC4626 standards and now ERC7540 for asynchronous vaults. We could use a reference implementation from OpenZeppelin
@Amxx @0xTimepunk more than happy to pickup where we left off on this PR, once we have designs mapped out.
The ERC was finalized two days ago 🎉
cc @Joeysantoro
@alphastorm @Joeysantoro @mw2000 I am very interested in a reference implementation for this which composes with the rest of the OpenZeppelin ERC20/4626 lifecycle hooks